Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manual Release 1.32.4 #4651

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Manual Release 1.32.4 #4651

merged 2 commits into from
Nov 11, 2024

Conversation

RotemAmit
Copy link
Contributor

@RotemAmit RotemAmit commented Nov 10, 2024 •
edited by samuelFain
Loading

1.32.4 (2024-11-10)

Breaking

  • The following commands will be deprecated and removed entirely in the next SDK release in two weeks: convert, create-content-artifacts, create-id-set, extract-code and lint.
  • Moved CJ102 to the new validate format. The validation's error number is now BA103 and it ensure that the tests section is either a non-empty list or "No tests".

Fix

  • Fixed an issue where getting a malformed file raised an non-indicative error.
  • Fixed an issue where the validate and create-id-set commands would fail to process correctly when encountering null values in the filters or transformers fields.

Internal

  • Moved RN113 to the new validate format. The validation ensures that all the first level headers in the release note are valid content types.
  • Moved RN115 to the new validate format. The validation ensure that the release notes first level headers are valid.

samuelFain
samuelFain reviewed Nov 10, 2024
View reviewed changes
samuelFain
samuelFain approved these changes Nov 10, 2024
View reviewed changes
Copy link
Contributor

@samuelFain samuelFain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Approved.
Please don't merge until the correct step in the release (after the release to Pypi is completed).
@RotemAmit Since we are doing a manual release - see if you can add the release changelog to the PR description to match previous release PRs (the current PR description will be copied and used in the Pypi release, so we want it to be consistent).

@samuelFain samuelFain added the release-sdk-to-pypi label to release SDK to pypi label Nov 10, 2024
@github-actions GitHub Actions
Copy link

Demisto-SDK 1.32.4 has been released successfully into pypi 😃

@RotemAmit RotemAmit merged commit 7de48ea into master Nov 11, 2024
27 of 29 checks passed
@RotemAmit RotemAmit deleted the 1.32.4 branch November 11, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelFain samuelFain samuelFain approved these changes

Assignees
No one assigned
Labels
release-sdk-to-pypi label to release SDK to pypi
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RotemAmit @samuelFain